ReadPlist should use biplist.readPlistFromString instead of biplist.readPlist

[hadar0x]

It turns out that biplist (which wraps plistlib) fails to parse plist files that have newlines and redundant white-spaces.

If you will replace biplist.readPlist with readPlistFromString, then we would be able to strip the newlines and white-spaces, and then we will not miss any plist file.

[ydkhatri]

Do you have a sample of such a plist, can you post it here. Also is this a macOS created one or by some other program?
Your proposed solution assumes that we already know this to be an XML plist, but it could be a binary one.

[hadar0x]

See attached - I had to zip it because GitHub don't support uploading plists.
com.apple.BluetoothService.zip

The file was was created by Empire.

In regards of the solution - correct. We can validate the type before doing so.

[ydkhatri]

Hmm, this is not valid XML as xml document must begin with <?xml, but macOS does not seem to care and plutil will read it just fine. Thanks for highlighting this, I will put in a fix.

[ydkhatri]

I put in a fix for it. Please check and let me know if there are still issues.

[hadar0x]

I checked and there's a new issue now:

MAIN.LAUNCHDAEMONS-ERROR-Failed to read plist /Library/LaunchDaemons/com.apple.BluetoothService.plist Error was : Exception from ReadPlist, trying to open file. Exception='unicode' does not have the buffer interface

When I wrapped it with str(data) - it worked. Of course there are other ways to handle it, just a quick suggestion.

[ydkhatri]

from __future__ import unicode_literals was the problem. Apparently biplist does not like unicode strings. I've added an explicit encode back to utf8 now. This should work now!

[hadar0x]

Works great. Thanks @ydkhatri