Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure exists works with array of values #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamstuartwilson
Copy link

Overview

When working with this lib I noticed that the exist method was double-wrapping an array of keys due to the way getKeysVarArgs was merging args. This adds a fix and test case to ensure users can use all of the following invocations:

client.exists('key', cb)
client.exists('key', 'key2', cb)
client.exists(['key', 'key2'], cb)

@iamstuartwilson
Copy link
Author

@kamiljano We have a workaround for this by shimming the exposed exists methods in our tests, but it would be great if you have time to review this PR. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant