feature: Chain swap #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fameal/ape-tax/9TjZbE1VD61iJgYFkp7WeqVNvCCF |
saltyfacu
approved these changes
Jul 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does ✨
In order to avoid a dead-end when you try to access a strategy on a network which is not your current metamask network, this pull request adds the
on_switch_chainmethod on theVaultscreen, based on the EIP 3085 and thewallet_addEthereumChainmethod.A new button is accessible on the
wrong-chainview, only if the destination network is not Ethereum Mainnet (currently not supported).The
chains.jsonfile now has a newchain_swapkey with all the needed information to be able to switch.How to test ✅
This is based on the PR-#65 (ethers fix).
The project should be able to start with a
yarn && yarn run serve.If you try to access a vault which is not on your current network (and not for mainnet), a button with
🔀 Switch it on Metamaskshould be available and should add then switch to the corresponding network.If the vault's chain is mainnet, the old layout should be displayed, preventing a misleading button.
Resources ✏️