Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Block Explorer on Vault Detail Page [WEB-856] #340

Closed
xgambitox opened this issue Oct 26, 2021 · 0 comments · Fixed by #348
Closed

Link to Block Explorer on Vault Detail Page [WEB-856] #340

xgambitox opened this issue Oct 26, 2021 · 0 comments · Fixed by #348
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@xgambitox
Copy link
Contributor

xgambitox commented Oct 26, 2021

Elevator Pitch
Add link to the block explorer of the vault address on the vault detail page.

Customer Value
Users can have an accessible link to the block explorer site in the vault detail page.

Definition of Done

  • Add block explorer link icon to the vault detail page view.
  • Link should open in a new tab.
  • Link should open correct block explorer for the currently selected network.
  • Icon should change to corresponding one of the network.

Design Approach
Add blockExplorerUrl property to NETWORK_SETTINGS on src/config/constants
Refactor VaultDetailPanels component to render icon.
Use currentNetwork on routes/VaultDetail as a new prop for VaultDetailPanels

Additional Context
image
Etherscan SVG here
FTMScan SVG here
Use this icon as default one for other networks we might add in the future.

@xgambitox xgambitox added enhancement New feature or request good first issue Good for newcomers labels Oct 26, 2021
@xgambitox xgambitox changed the title Link to Block Explorer on Vault Detail Page Link to Block Explorer on Vault Detail Page [WEB-856] Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant