Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

refactor: remove old API dependency #441

Merged
1 commit merged into from Nov 4, 2021
Merged

refactor: remove old API dependency #441

1 commit merged into from Nov 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2021

  • Removed old API dependency in as unobtrusive way as possible
  • Confirmed all vaults from yearn.finance are present
  • Confirmed all APY and vault assets are correct
  • Confirmed vault ordering is correct (one minor caveat is yvBOOST and yveCRV order are switched, but I actually think this is fine.. otherwise order is perfect. can change this if desired)
  • Confirmed all special vault display names and icon URLs are correct (there are two special vault icon overrides that rely on yearn-assets/icons rather than multichain. everything else uses multichain)

@ghost ghost requested review from dudesahn, nymmrx and xgambitox as code owners November 4, 2021 05:06
@vercel
Copy link

vercel bot commented Nov 4, 2021

@x48-crypto is attempting to deploy a commit to the Yearn Finance Team on Vercel.

A member of the Team first needs to authorize it.

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-441.d1d7icenyb7ii0.amplifyapp.com

Copy link

Important changes detected (payment related code)

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-441.d1d7icenyb7ii0.amplifyapp.com

Copy link

Important changes detected (payment related code)

@ghost ghost merged commit fe6993c into yearn:develop Nov 4, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants