This repository has been archived by the owner on Sep 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Nov 4, 2021
- Removed old API dependency in as unobtrusive way as possible
- Confirmed all vaults from yearn.finance are present
- Confirmed all APY and vault assets are correct
- Confirmed vault ordering is correct (one minor caveat is yvBOOST and yveCRV order are switched, but I actually think this is fine.. otherwise order is perfect. can change this if desired)
- Confirmed all special vault display names and icon URLs are correct (there are two special vault icon overrides that rely on yearn-assets/icons rather than multichain. everything else uses multichain)
@x48-crypto is attempting to deploy a commit to the Yearn Finance Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Important changes detected (payment related code)
|
ghost
commented
Nov 4, 2021
ghost
commented
Nov 4, 2021
ghost
commented
Nov 4, 2021
ghost
commented
Nov 4, 2021
ghost
commented
Nov 4, 2021
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Important changes detected (payment related code)
|
gotzenx
approved these changes
Nov 4, 2021
xgambitox
approved these changes
Nov 4, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.