Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add unsupervised boolean parameter to load_afq_data #71

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

richford
Copy link
Collaborator

This PR adds an unsupervised boolean parameter to load_afq_data, allowing the user to skip the loading of the target y csv file.

Resolves #70

@richford richford added enhancement New feature or request effort: low Not much effort needed to resolve this issue impact: medium A medium amount of effort needed to resolve this issue labels Apr 20, 2021
@richford richford requested a review from arokem April 20, 2021 11:23
…dwi_metrics in load_afq_data. Optionally concat the subject and session IDs in load_afq_data. Remove unnamed columns from nodes csv dataframe in load_afq_data
@arokem
Copy link
Collaborator

arokem commented Apr 20, 2021

LGTM! I think that a test that confirms the order and number of the outputs would make coveralls happy.

@richford richford merged commit 89e0761 into main Apr 20, 2021
@richford richford deleted the enh/unsupervised-load-afq-data branch April 20, 2021 18:04
@richford richford linked an issue Apr 20, 2021 that may be closed by this pull request
richford added a commit that referenced this pull request Jul 19, 2021
ENH: Add unsupervised boolean parameter to load_afq_data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Not much effort needed to resolve this issue enhancement New feature or request impact: medium A medium amount of effort needed to resolve this issue
Projects
None yet
2 participants