Segmentation Refactoring and Other Updates #136
Conversation
|
@arokem Take a look at the current Segmentation class / file. This should be ready to merge. |
There was a problem hiding this comment.
Here are a few comments.
The main comment I have about this is the comment I made in the api module: we want to make sure that the API for the segmentation functions is the same, so that we can reduce code duplication in api and lay the ground for more flexibility going forward.
Let's discuss when we meet later today.
| 'bundles', | ||
| 'CST_R.trk')) | ||
| 'bundles', | ||
| 'CST_R.trk')) | ||
|
|
||
|
|
||
| # def test_AFQ_data_recobundles(): |
There was a problem hiding this comment.
We should probably try to add a test using the 'reco' algorithm, but we probably need to remove this one -- it takes forever to run.
36000
force-pushed
the
resample-tracking
branch
from
102d3f7
to
1c55dbb
Compare
… because of other meanings of the word method)
… segmentation to better use set_number_of_points
|
@arokem , the only thing this needs is a reco API test. I won't be able to finish it today, but I think I resolved all the other comments if you want to look at them before you leave. |
|
Yeah - this all looks good. Let's go ahead and merge this and then add an issue to remind us to go back and add that test. |
In the process of putting segmentation into its own class. Added logging, option to resample. trying numba.