-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add cloudknot example #533
Conversation
c5cac51
to
f1e786f
Compare
56f1981
to
36aa6cb
Compare
ff49698
to
4957604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had some suggestions, particularly on the explanatory text in-between the code sections. I wonder whether we should also have another example that shows how to analyze HCP data locally. I have a script that I have been running on my laptop that can serve as the basis for that, so I could do that on a separate PR, if you think that it is a good idea.
I think a local example is a good idea. If its subsampled, it could also be run automatically with the other examples |
@arokem I believe this is ready for another review / merge |
Closes #440