Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add cloudknot example #533

Merged
merged 9 commits into from
Nov 13, 2020
Merged

[ENH] Add cloudknot example #533

merged 9 commits into from
Nov 13, 2020

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Oct 9, 2020 •
edited
Loading

  • simple cloudknot example
  • complicate cloudknot example compare tractography on hcp example
  • use ignore_pattern to ignore this example

Closes #440

@36000 36000 force-pushed the cloudknot_examples branch 3 times, most recently from c5cac51 to f1e786f Compare October 9, 2020 20:43
@bloomdt-uw bloomdt-uw mentioned this pull request Oct 10, 2020
Merged
16 tasks
@36000 36000 mentioned this pull request Oct 21, 2020
Merged
1 task
@36000 36000 changed the title [WIP] Add cloudknot example [ENH] Add cloudknot example Nov 10, 2020
arokem
arokem reviewed Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had some suggestions, particularly on the explanatory text in-between the code sections. I wonder whether we should also have another example that shows how to analyze HCP data locally. I have a script that I have been running on my laptop that can serve as the basis for that, so I could do that on a separate PR, if you think that it is a good idea.

examples/cloudknot_example.py Outdated Show resolved Hide resolved
examples/cloudknot_example.py Show resolved Hide resolved
examples/cloudknot_example.py Outdated Show resolved Hide resolved
examples/cloudknot_example.py Outdated Show resolved Hide resolved
examples/cloudknot_example.py Show resolved Hide resolved
examples/cloudknot_hcp_example.py Outdated Show resolved Hide resolved
examples/cloudknot_hcp_example.py Outdated Show resolved Hide resolved
examples/cloudknot_hcp_example.py Outdated Show resolved Hide resolved
examples/cloudknot_hcp_example.py Outdated Show resolved Hide resolved
examples/cloudknot_hcp_example.py Outdated Show resolved Hide resolved
@36000
Copy link
Collaborator Author

36000 commented Nov 12, 2020

I think a local example is a good idea. If its subsampled, it could also be run automatically with the other examples

@36000 36000 changed the title [ENH] Add cloudknot example [WIP] [ENH] Add cloudknot example Nov 12, 2020
@36000 36000 changed the title [WIP] [ENH] Add cloudknot example [ENH] Add cloudknot example Nov 12, 2020
@36000
Copy link
Collaborator Author

36000 commented Nov 13, 2020

@arokem I believe this is ready for another review / merge

@arokem arokem merged commit 2d523dd into yeatmanlab:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an example not run by the test suite that demonstrate pyAFQ used with cloudknot.
2 participants
@36000 @arokem