Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable esModuleInterop #19

Merged
merged 5 commits into from
Jan 9, 2021
Merged

Enable esModuleInterop #19

merged 5 commits into from
Jan 9, 2021

Conversation

yeeezsh
Copy link
Owner

@yeeezsh yeeezsh commented Jan 7, 2021 •
edited
Loading 

"esModuleInterop": true

will change from this

import * as request from 'supertest';

to this

import request from 'supertest';

and add test stage to distributed CI runner

@yeeezsh yeeezsh changed the title Enable interlop Enable interrop Jan 7, 2021
@yeeezsh yeeezsh changed the title Enable interrop Enable esModuleInterop Jan 7, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

yeeezsh
yeeezsh commented Jan 7, 2021
View reviewed changes
Copy link
Owner Author

@yeeezsh yeeezsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogo

octobrekids
octobrekids reviewed Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@octobrekids octobrekids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen

@yeeezsh
Copy link
Owner Author

yeeezsh commented Jan 9, 2021 •
edited
Loading

where my approve ka u edok

@yeeezsh yeeezsh merged commit 92b9be9 into master Jan 9, 2021
@yeeezsh yeeezsh deleted the es-interlop branch January 9, 2021 11:22
@yeeezsh yeeezsh mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octobrekids octobrekids octobrekids left review comments

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeeezsh @octobrekids