fix: wrap didSaveFile method with try-finally block
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximyurevich
changed the title
didSaveFile method with try-finally block
| lspserver.didSaveFile(bnr) | ||
| # TODO: implement `catch` block | ||
| # Wrap method with `try-finally` block to solve error: | ||
| # `E716: Key not present in Dictionary: "supportsDidSave"` |
There was a problem hiding this comment.
how this would happen?
| try | ||
| lspserver.didSaveFile(bnr) | ||
| finally | ||
| return |
There was a problem hiding this comment.
even it happened, just return or should continue?
There was a problem hiding this comment.
I didn't dive into the entire code base, I just hid the errors that appeared during programming. Perhaps it would be worthwhile to implement the ability to hide errors using a variable.
There was a problem hiding this comment.
though @yegappan accepted your/this PR, but i think:
- this didnot fix (or hid) the real err, since it perhaps was an init case, tho not sure how come that happened.
- and perhaps worse, since if that really happened, i thought it should
continueto next lspserver vsreturn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.