Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#567] add rackup to gemfile #571

Merged
merged 5 commits into from
Feb 9, 2024
Merged

[#567] add rackup to gemfile #571

merged 5 commits into from
Feb 9, 2024

Conversation

pnatashap
Copy link
Contributor

rackup is a separate module from rack 3.0.0, so should be added

@pnatashap
Copy link
Contributor Author

@yegor256 please take a look

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5ab64c) 34.92% compared to head (4598171) 34.92%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   34.92%   34.92%           
=======================================
  Files          47       47           
  Lines        1300     1300           
=======================================
  Hits          454      454           
  Misses        846      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yegor256
Copy link
Owner

yegor256 commented Feb 9, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 9, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6fa4ce5 into yegor256:master Feb 9, 2024
4 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 9, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants