Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade qulice to 0.17.3 #49

Closed
krzyk opened this issue May 9, 2018 · 21 comments
Closed

Upgrade qulice to 0.17.3 #49

krzyk opened this issue May 9, 2018 · 21 comments
Labels
bug Something isn't working

Comments

@krzyk
Copy link
Contributor

krzyk commented May 9, 2018

New qulice version brings following important changes:

  • removal of @author tag (it is prohibited now)
  • removal of @version tag (it is prohibited now)
  • license header should start with /* instead of /** - this will fix problem with IntelliJ reporting it as a javadoc that is not attached to any class
  • checkstyle validation performance improvement (speedup of ~ 10%)
    And few minor formatting changes.

Please upgrade the qulice and fix the new problems found.

@0crat
Copy link
Collaborator

0crat commented May 9, 2018

@llorllale/z please, pay attention to this issue

@llorllale
Copy link
Collaborator

@0crat in

@llorllale llorllale added the bug Something isn't working label May 15, 2018
@0crat 0crat added the scope label May 15, 2018
@0crat
Copy link
Collaborator

0crat commented May 15, 2018

@0crat in (here)

@llorllale Job #49 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

The job #49 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@victornoel
Copy link
Contributor

@llorllale should I also bump jcabi-parent to latest (0.49.2 -> 0.49.3)?

victornoel added a commit to victornoel/cactoos-http that referenced this issue May 19, 2018
victornoel added a commit to victornoel/cactoos-http that referenced this issue May 19, 2018
@victornoel
Copy link
Contributor

@0crat waiting for #55

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

@0crat waiting for #55 (here)

@victornoel The impediment for #49 was registered successfully by @victornoel/z

victornoel added a commit to victornoel/cactoos-http that referenced this issue May 19, 2018
@llorllale
Copy link
Collaborator

@victornoel I just looked (not too deeply) at releases for jcabi-parent - I don't see anything of real interest added in 0.49.3, or is there?

@victornoel
Copy link
Contributor

@llorllale I didn't see anything particular either, I just noticed it was the version used in cactoos-matchers for example and though it was always best to keep it at the latest version... not really justified :)

@llorllale
Copy link
Collaborator

@victornoel I think in cactoos-matchers I set it to the latest version while I was setting up the project just because it was the latest. It could easily have been 0.49.2 or whatever, so let's not worry about it for now.

@victornoel
Copy link
Contributor

@llorllale sure, thanks.

@0pdd
Copy link
Collaborator

0pdd commented May 28, 2018

@krzyk the puzzle #59 is still not solved.

@victornoel
Copy link
Contributor

@krzyk #55 was merged, you can now close this issue :)

@krzyk
Copy link
Contributor Author

krzyk commented May 28, 2018

@victornoel thanks

@krzyk krzyk closed this as completed May 28, 2018
@0crat
Copy link
Collaborator

0crat commented May 28, 2018

@elenavolokhova/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label May 28, 2018
@0crat
Copy link
Collaborator

0crat commented May 28, 2018

The job #49 is now out of scope

@elenavolokhova
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented May 28, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented May 28, 2018

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

@0pdd
Copy link
Collaborator

0pdd commented Jul 12, 2018

@krzyk the only puzzle #59 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants