-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to delete not utf8 java files and run it #173
Conversation
@timur-harin good start, but all filters we keep in the |
@timur-harin also, when your branch is ready, run |
@yegor256 are you talking about changing a file |
@timur-harin make a new one and call it |
@yegor256 I added a test and moved the script |
mkdir -p "$(dirname "${list}")" | ||
find "${home}" -type f -not -name '*.java' -print > "${list}" | ||
while IFS= read -r f; do | ||
rm -f "${f}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timur-harin looks like you delete ALL files, not only files with a broken encoding inside :)
@timur-harin why did you delete files from the |
@yegor256, in issue there is "delete non-UTF8 source Java files"
So I had to delete not UTF8 Java files in project |
@yegor256 If I am not right, correct me |
@timur-harin the objective of this filter is to delete files that have wrong encoding inside, which is not UTF-8 and not ASCII |
@timur-harin it was implemented in #285 |
@yegor256
In issue 169 you mentioned that you should delete not UTF8 source Java files
I think that we need also to have this script with showing which files were deleted which I put in the help folder