Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DOER metric #197

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Added DOER metric #197

merged 5 commits into from
Mar 16, 2024

Conversation

ocelot335
Copy link
Contributor

#126 was added

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 13, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 13, 2024

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 11min)

Whitesoces removed
@ocelot335
Copy link
Contributor Author

Well, I tried removing the wrong spaces

@ocelot335
Copy link
Contributor Author

@yegor256 could you please try to merge again?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 15, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 15, 2024

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 10min)

@yegor256
Copy link
Owner

@ocelot335 try to run make clean lint locally

Based on linter's message
@ocelot335
Copy link
Contributor Author

@yegor256, can you please try again?

@yegor256
Copy link
Owner

yegor256 commented Mar 16, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 16, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 16, 2024

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 10min)

@ocelot335
Copy link
Contributor Author

Well, I forgot to update number of metrics, sorry

Updated number of metrics
@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 16, 2024

@rultor merge

@ocelot335 @yegor256 Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

@ocelot335
Copy link
Contributor Author

@yegor256 Hope everything is ok now. I forgot to sync with yesterday's master commits

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 16, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2c07f6b into yegor256:master Mar 16, 2024
5 checks passed
@rultor
Copy link
Collaborator

rultor commented Mar 16, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@yegor256
Copy link
Owner

@ocelot335 thanks!

@ocelot335 ocelot335 deleted the DOER-branch branch March 17, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants