-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Getters & Setters metric #267
Conversation
@yegor256 Can you approve the workflows? |
@padjal try |
Removed commented and unused code
@yegor256 Good points, I have revised them and refactored the code. |
@yegor256 The only failing test locally is the jpeek, but I have not touched it |
@padjal try to install Maven locally and run again. Maven is required. |
@yegor256 Please see latest changes. |
@yegor256 I have fixed all linting errors. However, a failing test blocks the workflow: Locally, this test completes successfully: Could you have a look? |
@padjal try to push something new into the branch, the tests should pass |
@yegor256 Added something new as advised. |
@yegor256 Could you please have a look? |
@padjal now the problem is clearly related to your branch |
@yegor256 All I see is this Is this related to the new metric? |
@padjal yes, I think so, because of the name |
@yegor256 I cannot understand how the report creates such a file for the ast.py metric, but doesn't succeed to do it for the getset one. I have no idea how to debug |
@yegor256 Do you have any tips here? |
Added copyright protection to the linting step of the makefiles. Issue: yegor256#189
Changed the search term in the copyright linting function to check for the whole string, rather than just a single year. Issue: yegor256#189
@yegor256 I have fixed the output. Please review. |
@yegor256 Do you think that I should add anything else? |
@padjal as far as I understand, the idea was to count getters and setters in a class. Now, the description of the metric looks different. I don't understand what is "maximum complexity of getter"? Can you explain it better? |
@yegor256 I can change the main objective of the metric to be a counter of the getters and setters in a class. Do you think that this metric will yield any useful information? As per hour research paper, the original idea of the Getters and setters metric was something like this: Research question - How often are getters and setters not designed as expected? Now that I review this approach however, it might turn out that this is not a trivial task. Maybe your suggestion to just count the number of getter & setter methods in a class is better. Please tell me what you think and how I should proceed in this case. |
@yegor256 What do you think? |
@yegor256 I have changed the metric according to your suggestions. Please review. |
@yegor256 Can you review this, please? |
@padjal thanks! |
No description provided.