Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python code linter to Github Actions #336

Merged
merged 3 commits into from
May 22, 2024
Merged

Added python code linter to Github Actions #336

merged 3 commits into from
May 22, 2024

Conversation

nikzor
Copy link
Contributor

@nikzor nikzor commented May 21, 2024

@yegor256
In order to improve code support inside the repository, Python linter has been added as the new GitHub Actions workflow.
For the convenience of working inside the Jetbrains IDE set, an additional flag --max-line-length=120 was added, since this value is the default for the built-in PyCharm linter.
Check, please

@yegor256
Copy link
Owner

@nikzor looks good! However, check the status of GHA jobs - some of them fail now

@nikzor
Copy link
Contributor Author

nikzor commented May 22, 2024

@yegor256 Updated python-flake8-lint.yml
The Flake8 linter throws an error due to a mismatch in the length of a line in two files
Fixed in #320 and #322

@yegor256
Copy link
Owner

@nikzor now it works well, but I can't merge this pull request because it breaks the build in the master branch. You have to put the changes you made in #320 and #322 into this branch.

@nikzor
Copy link
Contributor Author

nikzor commented May 22, 2024

@yegor256
Check please, add changes from #320 and #322

@yegor256
Copy link
Owner

yegor256 commented May 22, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e2f4f3a into yegor256:master May 22, 2024
10 checks passed
@rultor
Copy link
Collaborator

rultor commented May 22, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 20min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants