Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#144 The current implementation of MWE metric expects information #244

Merged
merged 1 commit into from
May 25, 2018
Merged

#144 The current implementation of MWE metric expects information #244

merged 1 commit into from
May 25, 2018

Conversation

uurl
Copy link
Contributor

@uurl uurl commented May 21, 2018

Issue #144

This PR solves issue #144:
The current implementation of MWE metric expects information about LDA topics.

@0crat
Copy link
Collaborator

0crat commented May 21, 2018

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label May 21, 2018
@0crat
Copy link
Collaborator

0crat commented May 21, 2018

Job #244 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 21, 2018

@yegor256/z everybody who has role REV is banned at #244; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 25, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b324283 into cqfn:master May 25, 2018
@rultor
Copy link
Collaborator

rultor commented May 25, 2018

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 16min)

@codecov-io
Copy link

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage     74.44%   74.44%           
  Complexity      167      167           
=========================================
  Files            32       32           
  Lines          1041     1041           
  Branches         78       78           
=========================================
  Hits            775      775           
  Misses          234      234           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c88e5...b324283. Read the comment docs.

@0crat 0crat removed the scope label May 25, 2018
@0crat
Copy link
Collaborator

0crat commented May 25, 2018

The job #244 is now out of scope

@uurl
Copy link
Contributor Author

uurl commented May 31, 2018

@yegor256 It is merged, closed and I didn't receive any payment for this. What happened?

1 similar comment
@uurl
Copy link
Contributor Author

uurl commented Jun 5, 2018

@yegor256 It is merged, closed and I didn't receive any payment for this. What happened?

@yegor256
Copy link
Member

@uurl it's a pull request, you are not supposed to be paid for it. A reviewer is paid here, which was myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants