Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde dependency should be optional #16

Closed
DCNick3 opened this issue Apr 17, 2023 · 5 comments
Closed

serde dependency should be optional #16

DCNick3 opened this issue Apr 17, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@DCNick3
Copy link

DCNick3 commented Apr 17, 2023

Serde dependency is not really necessary for the functionality of the crate, only adding serialization capabilities. A common practice is to make it an optional dependency (see, for example, gram-rs here and here)
@yegor256
Copy link
Owner

@DCNick3 good point! Can you please submit a pull request?

@yegor256 yegor256 added the bug Something isn't working label Apr 17, 2023
yegor256 added a commit that referenced this issue Apr 23, 2023
@yegor256
#16 serde is optional
5131174
@yegor256
Copy link
Owner

@rultor release, tag is 0.0.7

@rultor
Copy link
Collaborator

rultor commented Apr 23, 2023

@rultor release, tag is 0.0.7

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Apr 23, 2023

@rultor release, tag is 0.0.7

@yegor256 Done! FYI, the full log is here (took me 3min)

@yegor256
Copy link
Owner

@DCNick3 it's fixed and released

yegor256 added a commit that referenced this issue Apr 23, 2023
@yegor256
#16 --all-features
9b65310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @rultor @DCNick3