Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation #159

Merged
merged 13 commits into from
Dec 31, 2023
Merged

Optimisation #159

merged 13 commits into from
Dec 31, 2023

Conversation

alexkazik
Copy link
Contributor

@alexkazik alexkazik commented Dec 31, 2023

Warning this is a breaking change since some of the Iter types change and the iter functions are no longer const (but others are).

Set Iter's uses slightly uncommon name. But the only way to go around it would be to export the set module and not via lib.

If you don't like parts of it, just tell me and I'll remove them.

I've also noticed that some, but not all, similar functions have must_use. And The functions names/types sometimes differ from HashMap.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Dec 31, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7e7565a into yegor256:master Dec 31, 2023
4 checks passed
@rultor
Copy link
Collaborator

rultor commented Dec 31, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

1 similar comment
@rultor
Copy link
Collaborator

rultor commented Dec 31, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@alexkazik alexkazik deleted the optimisation branch December 31, 2023 20:05
@yegor256
Copy link
Owner

yegor256 commented Jan 1, 2024

@alexkazik thanks a lot!!

@yegor256
Copy link
Owner

yegor256 commented Jan 1, 2024

@rultor release, tag is 0.0.15

@rultor
Copy link
Collaborator

rultor commented Jan 1, 2024

@rultor release, tag is 0.0.15

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jan 1, 2024

@rultor release, tag is 0.0.15

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants