-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisation #159
Merged
Merged
Optimisation #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency is not required.
This is how all other functions handle it.
Display has been moved into an own file.
It's more descriptive now and works with the upcoming commits together.
Now iter/iter_mut is a shorthand for the matching into_iter calls.
alexkazik
force-pushed
the
optimisation
branch
from
December 31, 2023 09:21
8c776f4
to
7e7565a
Compare
@rultor merge |
1 similar comment
@alexkazik thanks a lot!! |
@rultor release, tag is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning this is a breaking change since some of the Iter types change and the iter functions are no longer const (but others are).
Set Iter's uses slightly uncommon name. But the only way to go around it would be to export the set module and not via lib.
If you don't like parts of it, just tell me and I'll remove them.
I've also noticed that some, but not all, similar functions have
must_use
. And The functions names/types sometimes differ from HashMap.