Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15: Implementation of PartialEq for minimap::Map #17

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

Zefick
Copy link
Contributor

@Zefick Zefick commented Apr 17, 2023

No description provided.

@Zefick
Copy link
Contributor Author

Zefick commented Apr 17, 2023

Are documentation tests allowed?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.18 🎉

Comparison is base (7b68f51) 35.22% compared to head (2c3864f) 35.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   35.22%   35.40%   +0.18%     
==========================================
  Files           7        8       +1     
  Lines        1039     1045       +6     
==========================================
+ Hits          366      370       +4     
- Misses        673      675       +2     
Impacted Files Coverage Δ
src/lib.rs 14.53% <ø> (ø)
src/map.rs 87.85% <0.00%> (-1.43%) ⬇️
src/ctors.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 18, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2c3864f into yegor256:master Apr 18, 2023
@rultor
Copy link
Collaborator

rultor commented Apr 18, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@yegor256
Copy link
Owner

yegor256 commented Apr 18, 2023

@Zefick many thanks! I don't document tests usually. But documentation tests are very welcome :)

@yegor256
Copy link
Owner

@Zefick BTW, I would rather move this new functionality to a separate eq.rs file, for better readability

yegor256 added a commit that referenced this pull request Apr 19, 2023
yegor256 added a commit that referenced this pull request Apr 19, 2023
@Zefick Zefick deleted the 15 branch April 27, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants