Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete text field "attachment name..." #865

Closed
mkordas opened this issue Dec 12, 2015 · 15 comments
Closed

Obsolete text field "attachment name..." #865

mkordas opened this issue Dec 12, 2015 · 15 comments

Comments

@mkordas
Copy link
Contributor

mkordas commented Dec 12, 2015

Field "attachment name..." displayed when adding files to bouts doesn't seem to be used anywhere and it doesn't impact anything:
image

I think it should be removed. Or maybe I'm missing something?

@dmzaytsev
Copy link
Contributor

@mkordas I guess, there was an idea, "attachment name" should be a label for an attachment.
@yegor256 am I right?
if so field "attachment name" should be filled by a file name by default
unallowed chars like spaces or dashes should be replaced/removed as well

@yegor256
Copy link
Owner

@dmzaytsev yes, attachment name should be taken from the form field, not file name

@dmzaytsev
Copy link
Contributor

@karato it's a valid bug

@dmzaytsev
Copy link
Contributor

@mkordas Field "attachment name..." shouldn't be removed, however we have a bug here

@mkordas
Copy link
Contributor Author

mkordas commented Dec 15, 2015

@dmzaytsev should I rename the issue and change the description? Or just comments are enough?

@karato
Copy link
Collaborator

karato commented Dec 15, 2015

@karato it's a valid bug

@dmzaytsev I added bug tag to this ticket

@karato karato added the bug label Dec 15, 2015
@karato karato added this to the 3.1 milestone Dec 15, 2015
@karato
Copy link
Collaborator

karato commented Dec 15, 2015

@mkordas since there is no milestone yet I set it to "3.1"

@karato
Copy link
Collaborator

karato commented Dec 15, 2015

@mkordas many thanks for the report, I topped your account for 15 mins, transaction 566fecb821649a322a0000a7

@dmzaytsev
Copy link
Contributor

@mkordas I think comments are enough

@karato
Copy link
Collaborator

karato commented Jan 26, 2016

@jhyle this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here... This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

@jhyle
Copy link

jhyle commented Jan 28, 2016

@karato please find someone to review the PR #979

@karato
Copy link
Collaborator

karato commented Jan 28, 2016

@karato please find someone to review the PR #979

@jhyle thank you

@karato
Copy link
Collaborator

karato commented Feb 10, 2016

@jhyle 15 days already, in 48 hours I will re-assign. added -30 to your rating, now it is equal to +105

@jhyle
Copy link

jhyle commented Feb 10, 2016

@karato waiting for yegor256/takes#577

@karato
Copy link
Collaborator

karato commented Feb 11, 2016

@karato waiting for yegor256/takes#577

@jhyle agreed, take your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants