ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451

mkordas · 2015-08-01T22:46:49Z

I get the following exception while doing analysis of Checkstyle project:

[ERROR] Failed to execute goal com.qulice:qulice-maven-plugin:0.12.1:check (default-cli) on project checkstyle: Execution default-cli of goal com.qulice:qulice-maven-plugin:0.12.1:check failed: 8 -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.qulice:qulice-maven-plugin:0.12.1:check (default-cli) on project checkstyle: Execution default-cli of goal com.qulice:qulice-maven-plugin:0.12.1:check failed: 8
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:483)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal com.qulice:qulice-maven-plugin:0.12.1:check failed: 8
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 20 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 8
    at com.puppycrawl.tools.checkstyle.api.FileText.get(FileText.java:346)
    at com.puppycrawl.tools.checkstyle.api.FileText.get(FileText.java:54)
    at com.qulice.checkstyle.ImportCohesionCheck.check(ImportCohesionCheck.java:95)
    at com.qulice.checkstyle.ImportCohesionCheck.processFiltered(ImportCohesionCheck.java:75)
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:73)
    at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:263)
    at com.qulice.checkstyle.CheckstyleValidator.validate(CheckstyleValidator.java:92)
    at com.qulice.maven.CheckMojo.run(CheckMojo.java:83)
    at com.qulice.maven.CheckMojo.doExecute(CheckMojo.java:59)
    at com.qulice.maven.AbstractQuliceMojo.execute(AbstractQuliceMojo.java:175)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    ... 21 more

Do you need anything else to reproduce?

The text was updated successfully, but these errors were encountered:

davvd · 2015-08-05T09:17:01Z

@yegor256 please do something about this issue

yegor256 · 2015-08-05T09:31:50Z

@mkordas would be great to see your .java file where it crashes.

krzyk · 2015-11-02T10:26:26Z

@mkordas Could you add an example java file that causes this crash?

mkordas · 2015-11-02T21:55:01Z

@krzyk I don't know the file. Any hints how can I track it? I tried updating to Checkstyle 6.12 which reports problematic filename in stacktraces, but I didn't succeed with building qulice-maven-plugin locally: java.lang.ClassNotFoundException: com.qulice.spi.Environment or java.lang.NullPointerException at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromChildren(CollectionConverter.java:157

krzyk · 2015-11-03T07:18:00Z

@mkordas Maybe we could change this issue into a an upgrade to checkstyle 6.12? We could do a release and then you could check if qulice fails on your code, and if it does you would have the filename?

krzyk · 2015-11-03T07:20:59Z

@mkordas BTW is there an info about filenames in stack traces in Checkstyle realise notes? I can't find it.

mkordas · 2015-11-03T19:46:33Z

@krzyk
I think we can just create another issue to upgrade Checkstyle: #487

There is note about additional logging in release notes:

CLI should print a file name where exception is happen. Author: Roman Ivanov CLI should print a flie name where exception is happen checkstyle/checkstyle#2109

krzyk · 2015-11-03T20:01:54Z

@mkordas But until the checkstyle is upgraded this issue is not valid, without an example we don't know where is the problem.

mkordas · 2015-11-03T20:12:47Z

@krzyk OK, so I'm closing it.

mkordas · 2015-11-03T21:21:41Z

@krzyk I've managed to build Qulice with Checkstyle 6.12 locally (although I needed to do mvn install -Dmaven.test.skip=true install -Dinvoker.skip=true because tests were failing in my Windows environment) and here's nice end of stacktrace:

Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Exception was thrown while processing src\test\resources\Reproducer.java
    at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:282)
    at com.qulice.checkstyle.CheckstyleValidator.validate(CheckstyleValidator.java:89)
    ... 31 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 3
    at com.puppycrawl.tools.checkstyle.api.FileText.get(FileText.java:324)
    at com.puppycrawl.tools.checkstyle.api.FileText.get(FileText.java:58)
    at com.qulice.checkstyle.ImportCohesionCheck.check(ImportCohesionCheck.java:95)
    at com.qulice.checkstyle.ImportCohesionCheck.processFiltered(ImportCohesionCheck.java:75)
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:79)
    at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:266)
    ... 32 more

Minimal reproducer:

package com.google;

import java.util.*;

Note: this is valid and compilable Java file.

krzyk · 2015-11-04T06:48:30Z

@mkordas interesting case, thanks

krzyk · 2015-11-04T06:49:55Z

@mkordas could you add a he code above to the issue description? It will be easier to find.

krzyk · 2015-11-04T06:50:12Z

@davvd valid bug

davvd · 2015-11-04T09:06:35Z

@davvd valid bug

@krzyk I added bug tag to this ticket

mkordas · 2015-11-07T21:39:02Z

@mkordas could you add a he code above to the issue description? It will be easier to find.

@krzyk, is it fine now?

krzyk · 2015-11-08T06:53:33Z

@mkordas yes, thanks

krzyk · 2015-11-26T11:28:55Z

@davvd this is postponed

davvd · 2015-11-26T13:45:31Z

@davvd this is postponed

@krzyk OK, I put "postponed" label here

davvd · 2015-11-26T13:45:31Z

@davvd this is postponed

@krzyk no problem, I will try to find somebody else

davvd · 2015-12-09T13:47:30Z

@mkordas thanks for this report, I added 15 mins to your account, in transaction 566830ec6d5fb6522c0000c9

krzyk · 2016-01-17T15:43:43Z

@davvd this is not postponed

krzyk · 2016-01-17T15:43:56Z

@HDouss want to take this?

HDouss · 2016-01-17T15:55:59Z

@krzyk Yes please.

krzyk · 2016-01-17T16:00:17Z

@davvd assign @HDouss please

davvd · 2016-01-18T08:55:23Z

@davvd this is not postponed

@krzyk sure, thanks, I removed "postponed" tag to it

davvd · 2016-01-18T08:55:24Z

@davvd assign @HDouss please

@krzyk done. @HDouss the task is yours, please go ahead

HDouss · 2016-01-18T14:14:27Z

@mkordas The minimal reproducer here would fail because of NewlineAtEndOfFileCheck. That means I cannot add a unit test to make it pass. It won't pass anyway.

mkordas · 2016-01-18T16:20:37Z

@HDouss can't you just add newline at the end of file but still keep just imports?

HDouss · 2016-01-18T16:27:19Z

@mkordas Do you reproduce ArrayIndexOutOfBoundsException in ImportCohesionCheck for such a file ?

mkordas · 2016-01-19T08:39:09Z

@HDouss In August it was reproducible for me, I don't remember exactly how :) We just need any test case for the issue.

HDouss · 2016-01-20T10:19:11Z

@mkordas PR #626 reviewed and merged. Please close the issue.

mkordas · 2016-01-20T11:07:55Z

@HDouss thanks!

davvd · 2016-01-22T09:27:30Z

@HDouss Much obliged! I have added 30 mins to your account in payment "75231569", 72 hours and 20 mins spent

+30 to your rating, your total score is +1352

davvd mentioned this issue Nov 2, 2015

0.14 #484

Closed

mkordas closed this as completed Nov 3, 2015

mkordas reopened this Nov 3, 2015

davvd added bug DEV labels Nov 4, 2015

mkordas changed the title ~~ArrayIndexOutOfBoundsException in ImportCohesionCheck~~ ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only Nov 7, 2015

davvd added the postponed label Nov 26, 2015

yegor256 mentioned this issue Jan 14, 2016

0.16 #604

Closed

davvd removed the postponed label Jan 18, 2016

HDouss added a commit to HDouss/qulice that referenced this issue Jan 18, 2016

yegor256#451

10516c8

HDouss mentioned this issue Jan 18, 2016

ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451 #626

Merged

HDouss added a commit to HDouss/qulice that referenced this issue Jan 20, 2016

yegor256#451

1a4daf3

HDouss added a commit to HDouss/qulice that referenced this issue Jan 20, 2016

yegor256#451

4e3051c

mkordas closed this as completed Jan 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451

ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451

mkordas commented Aug 1, 2015

davvd commented Aug 5, 2015

yegor256 commented Aug 5, 2015

krzyk commented Nov 2, 2015

mkordas commented Nov 2, 2015

krzyk commented Nov 3, 2015

krzyk commented Nov 3, 2015

mkordas commented Nov 3, 2015

krzyk commented Nov 3, 2015

mkordas commented Nov 3, 2015

mkordas commented Nov 3, 2015

krzyk commented Nov 4, 2015

krzyk commented Nov 4, 2015

krzyk commented Nov 4, 2015

davvd commented Nov 4, 2015

mkordas commented Nov 7, 2015

krzyk commented Nov 8, 2015

krzyk commented Nov 26, 2015

davvd commented Nov 26, 2015

davvd commented Nov 26, 2015

davvd commented Dec 9, 2015

krzyk commented Jan 17, 2016

krzyk commented Jan 17, 2016

HDouss commented Jan 17, 2016

krzyk commented Jan 17, 2016

davvd commented Jan 18, 2016

davvd commented Jan 18, 2016

HDouss commented Jan 18, 2016

mkordas commented Jan 18, 2016

HDouss commented Jan 18, 2016

mkordas commented Jan 19, 2016

HDouss commented Jan 20, 2016

mkordas commented Jan 20, 2016

davvd commented Jan 22, 2016

ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451

ArrayIndexOutOfBoundsException in ImportCohesionCheck on file with imports only #451

Comments

mkordas commented Aug 1, 2015

davvd commented Aug 5, 2015

yegor256 commented Aug 5, 2015

krzyk commented Nov 2, 2015

mkordas commented Nov 2, 2015

krzyk commented Nov 3, 2015

krzyk commented Nov 3, 2015

mkordas commented Nov 3, 2015

krzyk commented Nov 3, 2015

mkordas commented Nov 3, 2015

mkordas commented Nov 3, 2015

krzyk commented Nov 4, 2015

krzyk commented Nov 4, 2015

krzyk commented Nov 4, 2015

davvd commented Nov 4, 2015

mkordas commented Nov 7, 2015

krzyk commented Nov 8, 2015

krzyk commented Nov 26, 2015

davvd commented Nov 26, 2015

davvd commented Nov 26, 2015

davvd commented Dec 9, 2015

krzyk commented Jan 17, 2016

krzyk commented Jan 17, 2016

HDouss commented Jan 17, 2016

krzyk commented Jan 17, 2016

davvd commented Jan 18, 2016

davvd commented Jan 18, 2016

HDouss commented Jan 18, 2016

mkordas commented Jan 18, 2016

HDouss commented Jan 18, 2016

mkordas commented Jan 19, 2016

HDouss commented Jan 20, 2016

mkordas commented Jan 20, 2016

davvd commented Jan 22, 2016