Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use xcop with ruby 2.7.1 due to obsolete nokogiri dependency #28

Merged
merged 1 commit into from Aug 5, 2020

Conversation

dgroup
Copy link
Contributor

@dgroup dgroup commented Apr 12, 2020

sparklemotion/nokogiri#1961

...
Fetching nokogiri 1.10.9 (x64-mingw32)
Installing nokogiri 1.10.9 (x64-mingw32)
Gem::RuntimeRequirementNotMetError: nokogiri requires Ruby version >= 2.3, <
2.7.dev. The current ruby version is 2.7.1.83.
An error occurred while installing nokogiri (1.10.9), and Bundler cannot
continue.
Make sure that `gem install nokogiri -v '1.10.9' --source
'https://rubygems.org/'` succeeds before bundling.

In Gemfile:
  xcop was resolved to 0.6, which depends on
    nokogiri

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2020

@yegor256/z please, pay attention to this pull request

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2020

@dgroup/z this pull request is too small, just 3 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@yegor256
Copy link
Owner

yegor256 commented Aug 5, 2020

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 5, 2020

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a92aea0 into yegor256:master Aug 5, 2020
@rultor
Copy link
Collaborator

rultor commented Aug 5, 2020

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)

@yegor256
Copy link
Owner

yegor256 commented Aug 5, 2020

@rultor release, tag is 0.6.1

@rultor
Copy link
Collaborator

rultor commented Aug 5, 2020

@rultor release, tag is 0.6.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Aug 5, 2020

@rultor release, tag is 0.6.1

@yegor256 Done! FYI, the full log is here (took me 5min)

@0crat
Copy link
Collaborator

0crat commented Aug 5, 2020

Job gh:yegor256/xcop#28 is not assigned, can't get performer

@yegor256
Copy link
Owner

yegor256 commented Aug 5, 2020

@dgroup thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants