Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR should be verified before it assign to CR #30

Closed
dmzaytsev opened this issue Jan 24, 2016 · 4 comments
Closed

PR should be verified before it assign to CR #30

dmzaytsev opened this issue Jan 24, 2016 · 4 comments

Comments

@dmzaytsev
Copy link

Right now a project manager assigns a code review to a pull request automatically, so we have four PR yegor256/takes#541 yegor256/takes#538 yegor256/takes#532 yegor256/takes#528 for the one ticket. Furthermore this ticket is not confirmed by the architect yet.

I would propose to make some checks before the assignment

  • PR description should contains a link to the ticket it is related to.
    PM should post a message with the quote from the policy if the link doesn't exists

Pull request description explains the solution proposed and contains a link to the original ticket it is related to.

  • The link should point to valid ticket that classified as a bug. PM should inform the developer if it's not a bug.
  • The developer should be assigned to that ticket. If his github account linked to Teamed.

When the developer posts a message addressed to the project manager, the PR should be checked again

@yegor256
Copy link
Owner

@dmzaytsev good point, thanks

@yegor256 yegor256 added the bug label Jan 25, 2016
@davvd
Copy link

davvd commented Jan 25, 2016

@dmzaytsev I am aware of the task, give me some time to find a developer...

@davvd
Copy link

davvd commented Jan 25, 2016

@dmzaytsev many thanks for the bug report, I added 15 mins to your acc, transaction 75337876

@yegor256
Copy link
Owner

yegor256 commented Jul 3, 2019

@original-brownbear I'm closing this task, since it's not relevant to this repo anymore. If you still believe that there is an issue in our Policy, please re-submit it to this repo: zerocracy/datum

@yegor256 yegor256 closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants