-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update copyright year #528
Conversation
@fabriciofx I think it would be more suitable to replace 2015 with 2016. Listing years means that we need to list all of them from the beginning - it wasn't done before so I think it's reasonable to have only one latest year. |
@fabriciofx I will find a reviewer for your pull requests shortly, thanks for contribution! |
@mkordas this pull request is for you,please review |
@fabriciofx you should ask @yegor256 to assign you to #523 |
@fabriciofx we should have |
@fabriciofx this is not a good solution, since we will have to do it every year, again and again (spending money for this). Instead, we should make sure the build breaks when the year in the license is wrong. This should happen automatically. |
@yegor256 who will be responsible to fix failed build on 1st Jan 2017? |
@fabriciofx please see how it was done in Qulice: yegor256/qulice#624 |
@fabriciofx the author of the first pull request. He/she simply won't be able to merge it, because of the check. |
@yegor256 make sense, thanks |
@fabriciofx do you need help? |
@mkordas I did a new patch, and pushed it to my fork, but it failed into travis test (permission denied to execute the ./years.sh script). Could you check it? |
@fabriciofx have you added execute permission? |
@mkordas yes. rwxr-xr-x permission here. |
@fabriciofx please follow the same approach as in yegor256/qulice#624, it was working there |
@mkordas I fixed it, but the problem now is with esd ruby package: https://travis-ci.org/yegor256/takes/builds/104171779. Should I delete this PR and resend it? |
@fabriciofx you can just trigger build again by pushing new commit or from Travis GUI |
@mkordas could you see it now? Passed in all tests! |
@ypshenychka please, check this issue for QA compliance, as per par.24 |
@fabriciofx First of all please make sure that ticket #523 is dispatched and you're assigned as a performer. Oterwise you will be simply not paid for your effort if another person will be assigned to it. . |
@fabriciofx Also why have you closed this PR and still continue work on it? |
@ypshenychka why you don't chase @fabriciofx for an answer? |
@ypshenychka thanks, I will be chasing @yegor256 |
@yegor256 can you dispatch #523? @ypshenychka is waiting for your decision |
@fabriciofx can you fix #627 in this PR? |
@ypshenychka #523 is closed, please decide about quality here |
@davvd Quality is bad. |
@exper0 what you think? It's good enough to close #523?