Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copyright year #528

Closed
wants to merge 1 commit into from
Closed

update copyright year #528

wants to merge 1 commit into from

Conversation

fabriciofx
Copy link
Contributor

@exper0 what you think? It's good enough to close #523?

@exper0
Copy link
Contributor

exper0 commented Jan 20, 2016

@fabriciofx I think it would be more suitable to replace 2015 with 2016. Listing years means that we need to list all of them from the beginning - it wasn't done before so I think it's reasonable to have only one latest year.
Btw, #523 is not classified and not assigned - not sure if this PR will be accepted.

@davvd
Copy link

davvd commented Jan 20, 2016

@fabriciofx I will find a reviewer for your pull requests shortly, thanks for contribution!

@davvd
Copy link

davvd commented Jan 20, 2016

@mkordas this pull request is for you,please review

@exper0
Copy link
Contributor

exper0 commented Jan 20, 2016

@davvd what about underlying issue #523 ? it's not even dispatched.

@mkordas
Copy link

mkordas commented Jan 20, 2016

@fabriciofx you should ask @yegor256 to assign you to #523

@mkordas
Copy link

mkordas commented Jan 20, 2016

@fabriciofx we should have 2015-2016 instead of 2015, 2016

@yegor256
Copy link
Owner

@fabriciofx this is not a good solution, since we will have to do it every year, again and again (spending money for this). Instead, we should make sure the build breaks when the year in the license is wrong. This should happen automatically.

@mkordas
Copy link

mkordas commented Jan 20, 2016

@yegor256 who will be responsible to fix failed build on 1st Jan 2017?

@mkordas
Copy link

mkordas commented Jan 20, 2016

@fabriciofx please see how it was done in Qulice: yegor256/qulice#624

@yegor256
Copy link
Owner

@fabriciofx the author of the first pull request. He/she simply won't be able to merge it, because of the check.

@mkordas
Copy link

mkordas commented Jan 20, 2016

@yegor256 make sense, thanks

@mkordas
Copy link

mkordas commented Jan 21, 2016

@fabriciofx do you need help?

@fabriciofx fabriciofx closed this Jan 22, 2016
@fabriciofx fabriciofx deleted the #523 branch January 22, 2016 02:08
@fabriciofx
Copy link
Contributor Author

@mkordas I did a new patch, and pushed it to my fork, but it failed into travis test (permission denied to execute the ./years.sh script). Could you check it?

@mkordas
Copy link

mkordas commented Jan 22, 2016

@fabriciofx have you added execute permission?

@fabriciofx
Copy link
Contributor Author

@mkordas yes. rwxr-xr-x permission here.

@mkordas
Copy link

mkordas commented Jan 22, 2016

@fabriciofx please follow the same approach as in yegor256/qulice#624, it was working there

@mkordas
Copy link

mkordas commented Jan 22, 2016

@fabriciofx
Copy link
Contributor Author

@mkordas I fixed it, but the problem now is with esd ruby package: https://travis-ci.org/yegor256/takes/builds/104171779. Should I delete this PR and resend it?

@mkordas
Copy link

mkordas commented Jan 22, 2016

@fabriciofx you can just trigger build again by pushing new commit or from Travis GUI

@fabriciofx
Copy link
Contributor Author

@mkordas could you see it now? Passed in all tests!

@davvd
Copy link

davvd commented Jan 23, 2016

@ypshenychka please, check this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@fabriciofx First of all please make sure that ticket #523 is dispatched and you're assigned as a performer. Oterwise you will be simply not paid for your effort if another person will be assigned to it. .

@ypshenychka
Copy link

@fabriciofx Also why have you closed this PR and still continue work on it?

@mkordas
Copy link

mkordas commented Feb 9, 2016

@ypshenychka why you don't chase @fabriciofx for an answer?

@ypshenychka
Copy link

@mkordas I see that there is no resolution by @yegor256 in #523. So I guess all we can do here is to wait until issue is dispatched.

@mkordas
Copy link

mkordas commented Feb 9, 2016

@ypshenychka thanks, I will be chasing @yegor256

@mkordas
Copy link

mkordas commented Feb 28, 2016

@yegor256 can you dispatch #523? @ypshenychka is waiting for your decision

@yegor256
Copy link
Owner

@mkordas I closed #523 and created another one: #627

@yegor256
Copy link
Owner

@fabriciofx can you fix #627 in this PR?

@mkordas
Copy link

mkordas commented Mar 11, 2016

@ypshenychka #523 is closed, please decide about quality here

@ypshenychka
Copy link

@davvd Quality is bad here since the PR was done without assignment and didn't bring any value for the project.
@mkordas I would advise you to not proceed with code review in such "unauthorized" PR until it is valid.

@ypshenychka
Copy link

@davvd Quality is bad.

@ypshenychka
Copy link

@davvd @yegor256 Please consider this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's update year in the header
6 participants