-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove_all method #12
Conversation
@@ -83,4 +83,22 @@ def test_remove_key_with_sync_false | |||
assert(cache.exists?(:hey) == false) | |||
assert(cache.exists?(:wey) == true) | |||
end | |||
|
|||
def test_remove_all_with_sync | |||
cache = Zache.new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qew7 we need a stronger test here. Try to use Threads
and do get()
and remove_all
at the same time in multiple threads. See what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 i dont really get what are we aiming here with threads, im not really expirienced in working with them
i added multiple threads creation with creating new values in cache and removing all values from cache, tests passed succesfully, can you please explain what we were aiming to test here?
@yegor256 ive remade remove_all logic, can you check it? |
@rultor merge |
@Qew7 @yegor256 Oops, I failed. You can see the full log here (spent 21s)
|
@Qew7 there are merge conflicts, see above. Please resolve them and let me know when the branch is ready. I will try to merge again. |
@yegor256 ive resolved conflicts, please try to merge again |
@rultor merge |
@yegor256 see issue #6