This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
[BUGFIX] Issue #51: ShadowDimensions does not update with ConcreteDimension #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new ConcreteQuestion as part of a ConcreteDimension that is a template, the associated ShadowDimensions do not reflect the change.
Codecov Report
@@ Coverage Diff @@
## develop #52 +/- ##
=======================================
Coverage 0.21% 0.21%
=======================================
Files 54 54
Lines 1404 1404
Branches 124 124
=======================================
Hits 3 3
Misses 1277 1277
Partials 124 124Continue to review full report at Codecov.
|
yeldiRium
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
strangedev
deleted the
fix/shadowdimensions-not-updating-with-concretedimension
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required logic was simply not implemented. This will resolve #51 .
This change is