-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promisify the codebase #1006
Comments
I'm in support of this. To take it a step further: is your proposal to strictly upgrade the codebase to use promises or are we talking about a shift to async/await as part of this switch away from callbacks? |
I think that's all our publicly facing API. For internal methods we should think about what to use instead of |
Woot. I'll take a look later today. Either Bluebird or https://github.com/sindresorhus/promise-fun/blob/master/readme.md#packages |
@SBoudrias Looks good. I think we should also deprecate the |
I like the idea of deprecating this.async() unless there's strong opposition. Seems like a sensible call for ergonomics. |
@mischah Noticed you added the in-progress label to this one. Are you working on it? :) |
This made it into 2.0.0 |
Would be nice to cleanup the codebase to use promises instead of callbacks: https://github.com/yeoman/generator/search?utf8=%E2%9C%93&q=cb
For public methods we could support both until the next major version and then remove callback support.
The text was updated successfully, but these errors were encountered: