Find all node_modules directories, not only nearest to root #442
Conversation
| nodeModules.forEach(function (root) { | ||
| if (!root) return; | ||
| var found = glob.sync('generator-*', { cwd: root, stat: true }) | ||
| .map(function( match ) { |
|
This will require some unit test. Also to make sure the generators are registered in the good older. Nearet |
| if (!root) return; | ||
| var found = glob.sync('generator-*', { cwd: root, stat: true }) | ||
| .map(function( match ) { | ||
| .forEach(function (root) { |
There was a problem hiding this comment.
no need for a line return before the forEach block.
|
I'm not sure about the way you refactored this. There's now two What I meant earlier was: |
|
Done. This line seems strange for me, because it is not clear, why concatenate in reverse order, but it does the needed behaviour - |
|
|
||
| describe('when there\'s ancestor node_modules/ folder', function() { |
|
I think we should also add a test to make sure local modules are prioritize over global modules. Mind taking care of this one as you're already on it? |
| @@ -20,6 +20,7 @@ describe('Environment Resolver', function () { | |||
| shell.exec('npm install', { silent: true }); | |||
| shell.exec('npm install generator-jquery', { silent: true }); | |||
| shell.exec('npm install -g generator-angular', { silent: true }); | |||
| shell.exec('npm install -g generator-dummy', { silent: true }); | |||
There was a problem hiding this comment.
you can put both on the same line so we only spawn a single process: npm install -g generator-angular generator-dummy
Findup searches for the first `node_modules` directory in cwd and it's ancestors, but what if our generators in `~/node_modules`, and we calling generator in directory, that has `node_modules`? Right - `yo` will think, that you have 0 generators. Closes yeoman#440
|
Merged npm installs. |
|
Thank you a lot for this one! Good work, keep them coming. |
|
Thanks for advices and code-review @SBoudrias ! I hope next time my code will be clearer. 😊 P.s. this pr will allow |
Findup searches for the first
node_modulesdirectory in cwd andit's ancestors, but what if our generators in
~/node_modules,and we calling generator in directory, that has
node_modules?Right -
yowill think, that you have 0 generators.Closes #440