File collision menu, tests for individual generators, mocha:generator and better looking output #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/*9999 I've been testing this out today, and it's awesome! |
|
wow wow wow! |
| @@ -70,10 +73,19 @@ actions.destinationRoot = function destinationRoot(root) { | |||
| // - the destination path to be relative to application Gruntfile's directory | |||
| // (most likely cwd) | |||
| actions.copy = function copy(source, destination, options) { | |||
| var self = this; | |||
There was a problem hiding this comment.
Can you use .bind(this) instead?
There was a problem hiding this comment.
alright 75b69eb9bc03d46edc527fbb72fad57150aadb41
|
Reviewed this PR, and it looks very good too me. A lot of awesome improvements. And the new collision handling is just marvelous! |
|
This is amazing work, @mklabs. Loving the new additions and cannot wait to land the collision handling. |
|
@addyosmani This looks good to me. Can we get this merged? |
|
@sindresorhus Happy to merge. @mklabs do you think you'll have time to rebase today? |
|
Yes doing it right now. |
|
Awesome. Looking forward to it :) |
* mv *.js lib/
* added file collision menu, checks every file system write,
* checking existing file, if it's identical. If it's not, shows up the
file collision menu (Y to overwrite, n to skip, d to compute file diff,
a to overwrite all, q to quit)
* Added tests for individual generators. Generators making use of
prompts are not tested yet (it requires us pulling in the Runnable
helper from yeoman)
* Auto-generation of tests with the generator generator
* Addition of mocha:generator, invoked by the generator one. Stubs
* out a new mocha test suite. Arguments can be used to setup file
assertions automatically.
* Set arguments required state based on provided defaults.
* Make sure to update the `this.options` hash in generator when
* using `this.option()`, setting up default value appropriately.
* add support/ directory, scripts to generate mocha specs for a given
generator. To use `./support/test <generator>` with <generator> being
the name of the generator. What it does, it goes into a temporary dir,
trigger the given generator, redirect the output and parse out the
created files, figures out the appropriate `yeoman init mocha:generator
...` command.
* fix fallbacks behavior
* move actions.js file into their own dir, automate the include
* detect image types, and setup noProcess accordingly
* use prompt directly, mainly to bypass the Are you sure? check on conflicts. * added log API for each status (identical, force, skip, ..) * shared to hook with any local generator (which might require another instance of logger). process.logging is used following logref spec: https://github.com/mikeal/logref * sort namespaces with help output * readme update
* move back to one describe / it * remove bash script, redone as much as possible as node script * all tests regenerated
|
Rebased, forced push. Should be ok now. |
|
Landed. Awesome work on this Mickael. It really improves the use of generators! |
mklabs
added a commit
that referenced
this pull request
Nov 21, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of stuff in there. The most relevant points being the file menu collision check on every file writes, and the reworked log output.
checking existing file, if it's identical. If it's not, shows up the
file collision menu (Y to overwrite, n to skip, d to compute file diff,
a to overwrite all, q to quit)
this.optionshash in generator whenusing
this.option(), setting up default value appropriately.out a new mocha test suite. Arguments can be used to setup file
assertions automatically.
prompts are not tested yet (it requires us pulling in the Runnable
helper from yeoman).
npm testis happy with 200+ tests.generator. To use
./support/test <generator>with<generator>beingthe name of the generator. What it does: it goes into a temporary dir,
trigger the given generator, redirect the output and parse out the
created files, figures out the appropriate
yeoman init mocha:generator ...command.Once again, most of the inspiration is coming from Rails generators.
New output:
Collision example:
thx to @sindresorhus for the screenshots! (and feedbacks)
Should close #38 #48 #58