-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npms.io to fetch data + use Github to store list through Travis-CI #52
Conversation
I am not ok with using travis to host the list as its not a true cdn and doesn't give all the benefits cloud storage does. the rest looks ok. working on moving the "build" system somewhere else so it can deploy easier |
Travis don't host the list who use on site. At end Github host the list. See https://github.com/zckrs/yeoman-generator-list/commits/cache-generators-list |
Right, we have had problems hosting on github. its not as fast, reliable or good as gcdn |
Totally true and that why I use http://rawgit.com
|
I think generating the list from Travis is good idea. We can talk about where we want to push the json list itself further. @zckrs can you setup the new process to run on a test branch with hourly build from Travis. We could leave it there for a week to make sure it runs fine and does correctly update the list every hour. I think that'd give us more confidence in relying on this new flow to generate the json list. |
Done. You can view commits here https://github.com/yeoman/yeoman-generator-list/commits/cache-generators-list Do you want I run the gh-pages of my fork of yeoman.github.io? |
Hej @zckrs, your solution seems to work like a charm 💖 I just wonder if its possible to make less noise? Yours, Michael |
Right I use my personal access token to push commit. I would like find a solution to avoid this noise. Maybe we should use a specifc user (https://github.com/yeoman-bot) but external to organization. Or create a new repo to store data |
Is this accurate? One of my generators isn't in the list anymore (https://github.com/diegohaz/generator-rest) and another is shown with 0 stars even though the repository has 300+ (https://github.com/diegohaz/arc, the generator code is in another branch). |
0 stars because npms.io not return a github object https://api.npms.io/v2/package/generator-arc You can compare your generator-arc with https://github.com/kriasoft/react-static-boilerplate who have a Yeoman generator in another branch. |
FYI about accuracy npms.io
|
I see. generator-react-static has the I was thinking that's because |
Maybe @satazor can help with this? |
@diegohaz Better open issue on npms repo |
@zckrs a git user is only an email and a name. It doesn't need to have an account on github. For yeoman.io we set it up as such https://github.com/yeoman/yeoman.github.io/blob/source/.travis.yml#L33 |
True but to have a personal access token we need a account registered currently is mine https://github.com/yeoman/yeoman-generator-list/pull/52/files#diff-354f30a63fb0907d4ad57269548329e3R11 |
@zckrs yes, that's required, but it doesn't link commits to your account. |
Any commits are linked to my account but activities yes. This is the problem of @mischah |
@SBoudrias How did you set up the token for this: |
You need to create an oauth token https://github.com/settings/developers |
Like I’ve described over here: |
Exactly like that |
Regarding the issue about these not having a |
@zckrs I think this setup looks good for now. Can you merge on master and set it up so it'll work from there? |
Done. @mischah about your issue on the spam in Github activites. Can you open a new issue to describe problem and discuss on a possible solution ? |
This PR groups the previously commit about use npms.io to fetch data (c928917) and adds a feature to store list of generators as JSON on Github to avoid dependency with a tiers server (9a08537).
Changes
yeoman-generator-list
Each build on Travis-CI for yeoman-generator-list will execute query on npms.io to store some informations about the generators.
If build succeed (and others conditions) we push a commit with the JSON list on a orphan branch of yeoman-generator-list (named
cache-generators-list
)yeoman.github.io (PR)
We would like get the latest version of list (example).
To accomplished:
How to update the list
curl -s -X POST -H "Travis-API-Version: 3" -H "Authorization: token secret_token_here" -H "Content-Type: application/json" -d '{"request":{"branch":"master"}}' https://api.travis-ci.org/repo/yeoman%2Fyeoman-generator-list/requests
(rate limit: 10req/hour)