-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define arithmetic and bitwise operations #314
Conversation
Do we need bitwise ops for signed integer types or it would it be better to omit those and add casts to unsigned types later? |
Ahh yes, that'd make more sense. Thanks! |
dcf3b85
to
d1115b4
Compare
d1115b4
to
4406f32
Compare
These will get “stuck” if they overflow, which is a little frustraing, but better than causing runtime errors!
Ok, this should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, you got these done super quick, nice 👍 Looks good to my untrained eyes.
This introduces a bunch of primitive operations for signed and unsigned integers. I need to figure out a better way of managing these primitives (I have some ideas about this), but I'm working with what I have right now!
Todo:
Future work:
Closes #257