New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-src-meta is a heavyweight dependency #827

Closed
snoyberg opened this Issue Aug 23, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@snoyberg
Member

snoyberg commented Aug 23, 2018

Sorry I'm only noticing this a year later, I realize I was pinged on #717. That PR introduced a dependency on haskell-src-meta in order to allow for parsing Haskell expressions. Unfortunately, that library introduces (via itself and dependencies) a relatively heavy compile time cost. I would like to propose that we move the Database.Persist.Sql.Raw.QQ module to a separate package so that users of persistent itself do not need to pay that cost. Any objection? Note that this would be a breaking change.

CC @felixSchl @cdepillabout @paul-rouse (commenters on the PR).

@snoyberg snoyberg closed this in 7c12ad4 Aug 28, 2018

snoyberg added a commit that referenced this issue Aug 28, 2018

Merge pull request #829 from yesodweb/separate-qq
Create separate persistent-qq (fixes #827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment