Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON instances require an extraneous id field for entities with a Primary #1036

Merged
merged 7 commits into from
Mar 31, 2020
Merged

JSON instances require an extraneous id field for entities with a Primary #1036

merged 7 commits into from
Mar 31, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Feb 12, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Fixes #1035

@parsonsmatt parsonsmatt added this to the 2.11 milestone Mar 31, 2020
parsonsmatt
parsonsmatt commented Mar 31, 2020
View reviewed changes
persistent-template/Database/Persist/TH.hs
-- { entityToJSON = 'keyValueEntityToJSON
-- , entityFromJSON = 'keyValueEntityFromJSON
-- { entityToJSON = 'entityIdToJSON
-- , entityFromJSON = 'entityIdFromJSON
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure when this was changed lol

@parsonsmatt parsonsmatt merged commit 948c528 into master Mar 31, 2020
@parsonsmatt parsonsmatt deleted the matt/json-encoding-primary branch March 31, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

JSON instances require an extraneous id field for entities with a Primary
1 participant
@parsonsmatt