Allow aeson 1.5 #1085
Merged
Allow aeson 1.5 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why'd you delete all the "things to do before/after submitting a PR"? I'd like to have a CHANGELOG entry and version bump for this - patch should do fine. Thanks! |
|
I thought it is not worth a version bump but only a revision, so I removed all of them. I'll update now. |
Builds fine and all tests pass here.
|
Ping re. commercialhaskell/stackage#5393, anything blocking this from being merged that I could help out on? |
87 tasks
|
Thanks for the ping - this LGTM and I'm happy to incorporate + make a HAckage revision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds fine and all tests pass here.