Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and rendering issues in docs #1314

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

eahlberg
Copy link
Contributor

@eahlberg eahlberg commented Sep 3, 2021

Fixes a couple of typos and Haddock rendering issues.

Before submitting your PR, check that you've:

  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@@ -203,7 +203,7 @@ You can automatically get ToJSON and FromJSON instances for any entity by adding
Person json
name Text
@
Requires @{-# LANGUAGE FlexibleInstances #-}@
Requires @\{\-\# LANGUAGE FlexibleInstances \#\-\}@
Copy link
Contributor Author

@eahlberg eahlberg Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires @{-# LANGUAGE FlexibleInstances #-}@ would render as Requires @@, see here under JSON instances. Maybe there's a better way to solve this than escaping each character?

@@ -16,7 +16,7 @@ module Database.Persist
-- This syntax allows you to customize the resulting Haskell datatypes and
-- database schema. See "Database.Persist.Quasi" for details on that definition
-- language.
--

Copy link
Contributor Author

@eahlberg eahlberg Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed in order to properly render the subheading Reference Schema & Dataset.

@@ -216,7 +216,7 @@ Person sql=peoples
name Text
@

== Change table/collection key definition (field name and/or type, persistent >= 2.1)
== Change table/collection key definition (field name and\/or type, persistent >= 2.1)
Copy link
Contributor Author

@eahlberg eahlberg Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping of the 2nd / was needed to render properly, see Change tablecollection key definition (field name andor type, persistent >= 2.1 on this page.

@eahlberg
Copy link
Contributor Author

eahlberg commented Sep 3, 2021

Found a couple of small issues in the docs that I figured I could have a go at. Since I'm a first-time contributor, CI won't run automatically so I haven't been able to see if it succeeds and cross off the task above, but the PR should be ready for review!

Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you 😄

@eahlberg
Copy link
Contributor Author

eahlberg commented Sep 3, 2021

No worries!

@parsonsmatt parsonsmatt merged commit 2b5c05d into yesodweb:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants