Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Num instance for OverflowNatural #1319

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

googleson78
Copy link
Contributor

@googleson78 googleson78 commented Sep 15, 2021

This is useful with things like castNum.

Didn't do these, since I'm not sure which ones are applicable:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This is useful with things like castNum.
@googleson78 googleson78 changed the title Add an Num instance for OverflowNatural Add a Num instance for OverflowNatural Sep 18, 2021
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@parsonsmatt parsonsmatt merged commit 47ae621 into yesodweb:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants