Add mysql json field support #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mysql and mysql-simple
parsonsmatt
approved these changes
Jan 27, 2022
| it "can select json with rawsql" $ db $ do | ||
| let testJSON = toJSON $ [object [ "test" .= ("value" :: Text) ]] | ||
| [[PersistByteString value]] <- runConduit $ rawQuery "select JSON_ARRAY(JSON_OBJECT('test', 'value'))" [] .| CL.consume | ||
| liftIO $ Just testJSON `shouldBe` (decode $ BSL.fromStrict value) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that mysql-simple and mysql have been updated to properly handle JSON values coming out of a mysql db (supported since mysql 5.7.8) this PR adds support to the MySQL backend to read these values. It does not add a PersistField instance for Value's. It is probably not great that Postgres has an orphan instance for Value. Would rather there be a Json newtype and JsonB newtype.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog