Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SomePersistField #1346

Conversation

halogenandtoast
Copy link
Contributor

@halogenandtoast halogenandtoast commented Dec 14, 2021

Issue

SomePersistField exists only to convert to PersistValue. Furthermore, we end up with a type-class instance with unexpected behavior due to how fromPersistValue works.

Solution

We can replace SomePersistValue with PersistValue directly.

After submitting your PR:

N.B.

Yesod book's description for the generated code should be updated as well.

TODO For Author

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt added this to the 2.14 milestone Dec 14, 2021
@parsonsmatt parsonsmatt merged commit ea09601 into yesodweb:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants