Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
SomePersistField
exists only to convert toPersistValue
. Furthermore, we end up with a type-class instance with unexpected behavior due to howfromPersistValue
works.Solution
We can replace
SomePersistValue
withPersistValue
directly.After submitting your PR:
N.B.
Yesod book's description for the generated code should be updated as well.
TODO For Author
(unreleased)
on the Changelog