Fix JSON import

[parsonsmatt]

Before submitting your PR, check that you've:

• Documented new APIs with Haddock markup
• Added @since declarations to the Haddock
• Ran stylish-haskell on any changed files.
• Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

• Update the Changelog.md file with a link to your PR
• Bumped the version number if there isn't an (unreleased) on the Changelog
• Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

[parsonsmatt]

Bug was here. withObject was not imported, so I think this turned into an UnboundVarE instead of a VarE that we want. Wow. Using the VarE 'withObject form forces the name to be in scope, which then becomes a NameG value.

@danbroooks TIL 😅

[parsonsmatt]

Surfaced problem in tests by doing this

[danbroooks]

Thanks for resolving this! Do you think it is worth adding a specific spec to cover imports required by users of persistent? Something like a test that only imports persistent, and defines some entities (some with derivied json instances) or do you think that might be overkill, something like:

module Database.Persist.TH.JsonEncodingSpec where

-- this test asserts this is the only import required
import Database.Persist.TH

mkPersist sqlSettings [persistLowerCase|
JsonEncoding json
    name Text
    age  Int
    Primary name
    deriving Show Eq
JsonEncoding2 json
    name Text
    age Int
    blood Text
    Primary name blood
    deriving Show Eq
JsonEncMigrationOnly json
    name Text
    age  Int
    foo  Text MigrationOnly
|]

My original PR added to JsonEncodingSpec but that was already importing Data.Aeson 😅 what you have done here seems to be a more robust solution, but I wonder if we should also add a test similar to the above? Happy to do the PR for this if so 😄

[parsonsmatt]

Yeah, that's a good idea.