ConnectionClosedByPeer vs IncompleteHeaders

[kazu-yamamoto]

Since [1] deleted ConnectionClosedByPeer, we cannot distinguish ConnectionClosedByPeer and IncompleteHeaders. Are there any ways to distinguish them with Conduit?

One idea is that if a buffer is empty and pull returns null bytestring, we take it as ConnectionClosedByPeer. Does this make sense? Is it possible to implement this idea? (I'm not familiar to the internal of Conduit, so I cannot.)

[1] 70bb530

[snoyberg]

I just pushed a commit for this. It's working on the new 1.2 code. Can you check this out when you have a chance?

[kazu-yamamoto]

I tried to build the environment but failed. I will try again when I can build the environment.

[gregwebs]

let us know what your build failures are

[kazu-yamamoto]

"Failures" just meant that "cabal install" on the wai packages from github failed in my environment. I don't have enough time to build proper environment this week. Sorry.

[kazu-yamamoto]

It seems to me that warp 1.2 does not solve this problem. When a client terminates the connection, warp displays "IncompleteHeaders".

[snoyberg]

You mean that the client terminates the connection in the middle of a response body, or before sending any headers?

[kazu-yamamoto]

Just before sending any headers (after getting one HTML by telnet).

[snoyberg]

OK, I think I got it this time. If no data is read, ConnectionClosedByPeer is thrown. If some data is read, then it becomes IncompleteHeaders.

[kazu-yamamoto]

I confirmed this works well and there is no leak of file descriptors. Let's close this issues.