Add allow-sendfilefd flag for Debian GNU/kFreeBSD #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian GNU/kFreeBSD (FreeBSD kernel plus glibc), the BSD flavour of sendfile is not usable, but Cabal treats kfreebsdgnu as os(freebsd) so I had to add a flag to simple-sendfile.cabal to make it possible to select the fallback implementation. See kazu-yamamoto/simple-sendfile#13 for more details. warp.cabal reflects the availability of interfaces from simple-sendfile, and so I believe it needs a matching flag to make it possible to forcibly disable the use of -DSENDFILEFD.
snoyberg
added a commit
that referenced
this pull request
Jun 15, 2013
Add allow-sendfilefd flag for Debian GNU/kFreeBSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian GNU/kFreeBSD (FreeBSD kernel plus glibc), the BSD flavour of
sendfile is not usable, but Cabal treats kfreebsdgnu as os(freebsd) so I
had to add a flag to simple-sendfile.cabal to make it possible to select
the fallback implementation. See
kazu-yamamoto/simple-sendfile#13 for more
details.
warp.cabal reflects the availability of interfaces from simple-sendfile,
and so I believe it needs a matching flag to make it possible to
forcibly disable the use of -DSENDFILEFD.