Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warp: only add Server header if there is none in the response headers #943

Closed
wants to merge 2 commits into from
Closed

warp: only add Server header if there is none in the response headers #943

wants to merge 2 commits into from

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Oct 5, 2023 •
edited
Loading

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Found a fixme in warp that was pretty easy to fix, so I fixed it.

@Vlix Vlix mentioned this pull request Oct 5, 2023
Closed
3 tasks
@kazu-yamamoto
Copy link
Contributor

Probably I will have time to review these two issue in the next week.
Have a good weekend.

kazu-yamamoto
kazu-yamamoto approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Oct 13, 2023
@kazu-yamamoto
Merge PR yesodweb#943
a4dc698
@kazu-yamamoto
Copy link
Contributor

Rebased and merged. Thanks!

@Vlix Vlix deleted the small-fixme-to-server-header-adding branch October 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto