Add jsAttributesHandler #1622
Merged
Add jsAttributesHandler #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `jsAttributesHandler` to run arbitrary Handler code before building the attributes map for the script tag generated by `widgetFile`. This is useful if you need to add a randomised nonce value to that tag. Closes #1621
snoyberg
reviewed
Aug 26, 2019
This addresses this comment: #1622 (comment)
snoyberg
approved these changes
Aug 26, 2019
| -- | ||
| -- @since 1.6.16 | ||
| jsAttributesHandler :: HandlerFor site [(Text, Text)] | ||
| jsAttributesHandler = getYesod >>= return . jsAttributes |
There was a problem hiding this comment.
This can also be written as jsAttributes <$> getYesod, but there difference isn't that improtant.
There was a problem hiding this comment.
I'm happy to make that change, and also some more hlint-driven cleanup along the way.
snoyberg
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
jsAttributesHandlerto run arbitrary Handler code before building the attributes map for the script tag generated bywidgetFile. This is useful if you need to add a randomised nonce value to that tag.Closes #1621
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: