Replace decodeFile with decodeFileEither #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGabriel
reviewed
Jan 27, 2020
yesod/Yesod/Default/Config.hs
Outdated
| Nothing -> fail $ "Invalid YAML file: " ++ show fp | ||
| Just (Object obj) | ||
| Left err -> | ||
| fail $ "Invalid YAML file: " <> show fp <> " " <> prettyPrintParseException err |
There was a problem hiding this comment.
It looks like tests are failing on old versions of GHC/base, where <> isn't in scope
yesod > /home/vsts/work/1/s/yesod/Yesod/Default/Config.hs:238:40: error:
yesod > • Variable not in scope: (<>) :: m0 a0 -> String -> t1
yesod > • Perhaps you meant one of these:
yesod > ‘<$>’ (imported from Prelude), ‘*>’ (imported from Prelude),
yesod > ‘<$’ (imported from Prelude)
yesod > |
yesod > 238 | fail $ "Invalid YAML file: " <> show fp <> " " <> prettyPrintParseException err
There was a problem hiding this comment.
Oh my bad. I fixed it but how did you run those tests? By running stack test I didn't see any failures.
There was a problem hiding this comment.
I didn't run them, that was continuous integration. It tests against a bunch of different configurations. I don't have exact instructions, but you could copy what CI does to test against different configurations (probably just changing the resolver in the stack file)
v0d1ch
force-pushed
the
1655_Replace-decodeFile-with-decodeFileEither
branch
from
6d11b67
to
cfaf517
Compare
MaxGabriel
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all...