Use DeriveLift to generate yesod-core's Lift instances #1664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC 8.0 and later come with the
DeriveLift
extension for deriving instances ofLanguage.Haskell.TH.Syntax.Lift
.yesod-core
supports GHC 8.2 and up, so it is able to make use of this. Not only doesDeriveLift
make for much shorter code, but it also fixes warnings that you get when compilingyesod-core
with GHC 8.10 or later:This is because
DeriveLift
fills in implementations ofliftTyped
, a method that was introduced toLift
intemplate-haskell-2.16.0.0
(bundled with GHC 8.10).After submitting your PR: