Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sometimes failing superfluous test #1756

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

jappeace
Copy link
Contributor

@jappeace jappeace commented Mar 25, 2022

This test sometimes fails on nix builds.
I'm not sure why, but it should be superfluous with
"thread killed = 500" test anyway.

They test both for async exceptions.
Just a different one.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This test sometimes fails on nix builds.
I'm not sure why, but it should be superflous with
"thread killed = 500" test anyway.

They test both for async exceptions.
Just a different one.
@jappeace jappeace changed the title Remove sometimes failing test Remove sometimes failing superflous test Mar 25, 2022
@jappeace jappeace changed the title Remove sometimes failing superflous test Remove sometimes failing superfluous test Mar 25, 2022
@jappeace
Copy link
Contributor Author

this was introduced in #1753

@snoyberg snoyberg merged commit d831b9f into yesodweb:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants