config to control the behavior of the CallsMonitoring job #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
1526-CallsMonitoring-teardown-rules
branch
from
e1067f2
to
c98a95d
Compare
Ivanov-Anton
force-pushed
the
1526-CallsMonitoring-teardown-rules
branch
4 times, most recently
from
be8f6e7
to
7a2d9cd
Compare
Ivanov-Anton
commented
Aug 10, 2024
Ivanov-Anton
added
the
Waiting for code review
|
@dmitry-sinina this PR is ready to code review |
Ivanov-Anton
force-pushed
the
1526-CallsMonitoring-teardown-rules
branch
2 times, most recently
from
689c997
to
f1778a9
Compare
Ivanov-Anton
removed
the
Waiting for code review
|
@dmitry-sinina this PR is ready to code review |
senid231
requested changes
Aug 15, 2024
| if disabled_orig_gw_active_calls.key?(call[:orig_gw_id]) | ||
| terminate_calls_for_disabled_orig_gw(call) | ||
| elsif disabled_term_gw_active_calls.key?(call[:term_gw_id]) | ||
| terminate_calls_for_disabled_term_gw(call) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I think better would be to split detect_gateway_calls_to_reject into 2 methods: detect_orig_gateway_calls_to_reject and detect_term_gateway_calls_to_reject and use same approach that was used in detect_customers_auth_calls_to_reject
P.S. also please refactor adding calls to @terminate_calls, they all should use terminate_calls method
def detect_orig_gateway_calls_to_reject
return unless teardown_enabled?(:teardown_on_disabled_orig_gw)
calls_to_terminate = flatten_calls.select do |call|
disabled_orig_gw_active_calls.key?(call[:orig_gw_id])
end
terminate_calls(calls_to_terminate)
end
def detect_term_gateway_calls_to_reject
return unless teardown_enabled?(:teardown_on_disabled_term_gw)
# same
end
def terminate_calls(calls)
@terminate_calls.merge!(calls.index_by { |c| c[:local_tag] })
end
Ivanov-Anton
force-pushed
the
1526-CallsMonitoring-teardown-rules
branch
2 times, most recently
from
0fc61bf
to
5edfe3c
Compare
|
@senid231 just appliyed your last suggestion. |
Ivanov-Anton
added
the
Waiting for code review
|
new config variables should be described there: https://github.com/yeti-switch/yeti-web/blob/master/config/initializers/_config.rb#L25 |
introduces new configuration options in yeti_web.yml to control the behavior of the CallsMonitoring job when dealing with disabled customer authentication and both origination/termination gateways: - calls_monitoring.teardown_on_disabled_customer_auth - calls_monitoring.teardown_on_disabled_term_gw - calls_monitoring.teardown_on_disabled_orig_gw The CallsMonitoring class has been updated to use these configurations in the relevant methods. If the configs are not present, the current flow should not be changed.
Ivanov-Anton
force-pushed
the
1526-CallsMonitoring-teardown-rules
branch
from
5edfe3c
to
31cb475
Compare
|
just appliyed your last suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add config to control the behavior of the CallsMonitoring job
introduces new configuration options in yeti_web.yml to control
the behavior of the CallsMonitoring job when dealing with
disabled customer authentication and both origination/termination gateways:
The CallsMonitoring class has been updated to use these
configurations in the relevant methods. If the configs
are not present, the current flow should not be changed.
Additional links
closes #1526