1554, Invoice auto approve configuration #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ivanov-Anton
force-pushed
the
1554-invoice-auto-approve
branch
5 times, most recently
from
c19554a
to
270d6a0
Compare
Ivanov-Anton
added
the
Waiting for code review
config/initializers/_config.rb
Outdated
| @@ -90,6 +90,10 @@ def self.setting_files(config_root, _env) | |||
| end | |||
|
|
|||
| optional(:customer_api_cdr_hide_fields).array(:string) | |||
|
|
|||
| optional(:invoice).schema do | |||
| required(:auto_approve).value(:bool) | |||
There was a problem hiding this comment.
auto_approve should be optional and by default false
There was a problem hiding this comment.
ok I will change as optional and regarding default behavious
by default application will not approve invoice after generation
file: app/services/billing_invoice/generate.rb
approve_invoice!(invoice) if YetiConfig.invoice&.auto_approve
Ivanov-Anton
force-pushed
the
1554-invoice-auto-approve
branch
from
270d6a0
to
e7f34a3
Compare
Ivanov-Anton
removed
the
Waiting for code review
Ivanov-Anton
requested review from
dmitry-sinina
and removed request for
senid231
Ivanov-Anton
commented
Sep 23, 2024
| @@ -4,6 +4,8 @@ module BillingInvoice | |||
| class Fill < ApplicationService | |||
| parameter :invoice, required: true | |||
|
|
|||
| Error = Class.new(ApplicationService::Error) | |||
There was a problem hiding this comment.
This class has been introduced because when we use the BillingInvoice::Fill service, we expect it to raise an error of type BillingInvoice::Fill::Error. However, currently, the service raises an error of type ApplicationService::Error, which is not the expected behavior. When I want to catch service king of error class I'll use ApplicationService::Error explicitly.
Ivanov-Anton
added
the
Waiting for code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional links
closes #1554