New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router switch example should be converted to a suite of tests #1568

Closed

jstarry opened this issue Sep 20, 2020 · 1 comment · Fixed by #1559

Labels

Member

jstarry commented Sep 20, 2020

Context from @hgzimmerman:

Come to think of it, the switch example really isn't an example and is more of a mediocre/manual test suite. Its not meant to be ran in the browser.
I think it should be converted into a test/ directory instead - but that's outside of the scope of this PR.

jstarry added the A-yew-router label

Member

siku2 commented Sep 20, 2020

I guess I'll take care of this in #1559. I intended to remove it entirely first but reusing it as a test makes sense.

siku2 mentioned this issue

Build examples with trunk #1559

Merged

3 tasks

siku2 closed this as completed in #1559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment